| Author |
Topic  |
|
Coolwind
Moderator
    
Italy
7473 Posts |
Posted - 22/01/2012 : 18:54:34
|
BUG found drawing coast line. Coast lines are not drawn in 2.3u. I must have broken something while fixing topology for non-metric distances.
|
 |
|
|
davesalmon
Pterodattilo
    
United Kingdom
901 Posts |
Posted - 22/01/2012 : 20:31:58
|
"I think you are misunderstanding how we pick up the first three". No misunderstanding, that is exactly as I understood it, and why cup was not picking up the trigraph. If it is a problem, I suppose I could modify the cup file using a csv file to put the trigraph first. Or ask Jeff Goodenough who has a really good program called TPSelect, that produced waypoint files from the UK BGA waypoint file, in any format you can think of, to do a special cup format with the trigraph in front of the name. We could call it LK8000 format. |
 |
|
|
Coolwind
Moderator
    
Italy
7473 Posts |
Posted - 22/01/2012 : 21:54:01
|
I try to explain better, Dave. There was a problem indeed, now fixed, that prevented your DAT file to be loaded. However, when you say that you use that DAT and not the other CUP, I can tell you that the only difference for LK is the name of the waypoints. In DAT the name is the one that fits your need for the first 3 letters, in CUP it does not. This has nothing to do with LK! We are NOT using the 3 letters in DAT at the beginning of each line, this is what I am telling you.
In any case, now it is fixes so you can load again those waypoints (2.3v).
|
 |
|
|
davesalmon
Pterodattilo
    
United Kingdom
901 Posts |
Posted - 22/01/2012 : 22:44:50
|
| OK, thanks. |
 |
|
|
eric.carden
Falchetto
 
USA
198 Posts |
Posted - 24/01/2012 : 22:29:16
|
I haven't had time to test this more fully yet (maybe tonight), but I wanted to report it in case it's new. While using LK 2.3u with Condor with 24 kt (44 km/h) winds, the snail trail misbehaved in circling zoom.
For what it's worth, I was flying a sailplane (of course) but had LK set up like for my (real-world) hang glider. Except for the high winds, I've done this plenty of times before without having a problem, so I'm guessing the high winds (I've never set them this high in Condor before) are a key part of the scenario.
The problem was that the trail (1) wasn't as long as usual and (2) would vanish at intermediate points (i.e., not at the oldest points first). So I only got about one full circle of trail - usually with a piece of the circle missing, which looks a lot like zero lift (very thin line) unless I look very closely.
I'm not sure whether older versions would have had the same behavior (I can try if desired), because I've never quite used LK in this scenario before. My biggest real-life cross-country flight, though, was with winds this strong aloft, so it's important to me that this work in my hang glider with winds this strong.
If this is a new issue and you'd like more details, let me know what details would be most helpful, and I'll provide them.
Eric |
 |
|
|
Coolwind
Moderator
    
Italy
7473 Posts |
Posted - 24/01/2012 : 22:54:07
|
New issue. However you should first be able to replicate it on 2.3, and then check that in 2.2 it did work correctly.
|
 |
|
|
AlphaLima
Moderator
    
Germany
826 Posts |
Posted - 25/01/2012 : 09:07:13
|
Just as an idea, have you checked Trail drift ON/OFF in the Config 3 dialog?
|
 |
|
|
eric.carden
Falchetto
 
USA
198 Posts |
Posted - 25/01/2012 : 15:58:56
|
I did some testing last night, and I found that the problem is the same in v2.2e as in v2.3u. The problem's there in "glider" mode, too, not just "Paraglider/HangGlider" mode. I tested wind speeds of 4, 8, 12, 16, 20, & 24 kts and saw the problem in all cases except the 4 kt case. The problem may have been more severe with increasing wind speed. Then I turned trail drift off (I prefer it on) and re-tested (only at 24 kts), and there wasn't a problem. So it seems to be a problem with trail drift that manifests itself more and more with increasing wind speed.
Eric |
 |
|
|
Coolwind
Moderator
    
Italy
7473 Posts |
Posted - 25/01/2012 : 16:21:57
|
| Ok It wont be fixed in this case, not by me at least, for 3.0. |
 |
|
|
eric.carden
Falchetto
 
USA
198 Posts |
Posted - 05/03/2012 : 00:54:31
|
I dug around, found what I believe is the problem, and just issued a pull request for changes to LKDrawTrail.cpp to fix the problem. The code was/is trying to figure out whether a drifted point will be on screen without first figuring where that point should be drawn. It was using an overly-conservative (to avoid trying to show an off-screen point) approach, and with high winds and a very zoomed-in view, points are being omitted that should be shown. Be gentle, as I'm new to this Git/Github stuff. :-)
I haven't figured out how to set up my development environment to create PNA EXEs, so I haven't been able to test the fix. I'll be happy to test it, if you can provide me a PNA EXE including the changes I made.
Thanks,
Eric
P.S. - I know you're busy with documentation. This issue isn't urgent. |
 |
|
|
Coolwind
Moderator
    
Italy
7473 Posts |
Posted - 05/03/2012 : 01:19:49
|
Got the reversible fix, lovely because there is no problem to do testing with it! merging later this evening |
 |
|
|
eric.carden
Falchetto
 
USA
198 Posts |
Posted - 12/07/2012 : 18:44:26
|
Oops. I apparently forgot to report back about the trail drift bug I fixed (a fix that I see isn't in v3.0c). On 3/29/12, I finally created my first PNA EXE, and I tested the fix using Condor. I've been using the fix in all flights (Condor and real) since then, and I've accrued probably 30 flight hours (mostly Condor) with the fix with it always working as expected.
Eric |
 |
|
|
mazuk
Falchetto
 
Germany
112 Posts |
Posted - 13/07/2012 : 10:12:06
|
Eric,
are you going to push the trail fix also to your fork?
ciao Mazuk |
 |
|
|
eric.carden
Falchetto
 
USA
198 Posts |
Posted - 13/07/2012 : 15:22:55
|
Hi Mazuk,
I pushed the fix March 4, and Paolo merged it the next day. It's been in the LK master branch (and all beta versions) since then - it just didn't make it into the May 18 3.0c release.
Eric |
 |
|
|
mazuk
Falchetto
 
Germany
112 Posts |
Posted - 13/07/2012 : 15:41:55
|
| Ok, thank you Eric. |
 |
|
Topic  |
|